Skip to content

Conversation

@jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Sep 19, 2024

Issue #, if available:

Description of changes:

  1. Upgrade all OTel dependencies
    i. Resolve issue where auto-configuration-propagators depended on a newer version of the opentelemetry/core package compared to other dependencies. Now it should be the same version that is used by other dependencies.

  2. Use new semantic attributes from latest OTel JS attributes in XRay Sampler
    See: https://github.com/open-telemetry/semantic-conventions/blob/ab0e4b4b2ba037e2d678e31d5a10fb55563bc698/docs/attributes-registry/http.md?plain=1#L85-L100
    See: similar Python logic

  ATTR_CLIENT_ADDRESS,
  ATTR_HTTP_REQUEST_METHOD,
  ATTR_SERVER_ADDRESS,
  ATTR_URL_FULL,
  ATTR_URL_PATH,

Testing:

  • Tested on ECS Fargate and Local machine

image

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from a team as a code owner September 19, 2024 04:11
@mxiamxia mxiamxia merged commit e794e75 into main Sep 19, 2024
8 checks passed
@mxiamxia mxiamxia deleted the upgrade-otel branch September 19, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants